chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc - Issue 1838623002: Bring Audio Share and Tab Share Default On

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 1838623002: Bring Audio Share and Tab Share Default On (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc ('k') | chrome/browser/media/desktop_capture_access_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

index d30e2408c888c09f4323378f2bdaf992e5fa0ac5..6c424b4d29acdedbb8c1eb516bccc8e28aa3fec0 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

@@ -97,16 +97,16 @@ bool DesktopCaptureChooseDesktopMediaFunctionBase::Execute(

break;

case api::desktop_capture::DESKTOP_CAPTURE_SOURCE_TYPE_TAB:

- if (base::CommandLine::ForCurrentProcess()->HasSwitch(

- extensions::switches::kEnableTabForDesktopShare)) {

+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

+ extensions::switches::kDisableTabForDesktopShare)) {

show_tabs = true;

}

break;

case api::desktop_capture::DESKTOP_CAPTURE_SOURCE_TYPE_AUDIO:

bool has_flag = base::CommandLine::ForCurrentProcess()->HasSwitch(

- extensions::switches::kEnableDesktopCaptureAudio);

- request_audio = has_flag;

+ extensions::switches::kDisableDesktopCaptureAudio);

+ request_audio = !has_flag;

break;

}