Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1838593002: Replace IS_OBJECT with IS_RECEIVER in regexp.js (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace IS_OBJECT with IS_RECEIVER in regexp.js "IS_RECEIVER" used to be called "IS_SPEC_OBJECT", which might be a better name: it's what the spec means when it says "Type(O) is Object". R=littledan@chromium.org BUG=v8:4602 LOG=n Committed: https://crrev.com/fafa7635891d4d04f5003e15fa154b725ca53d0d Cr-Commit-Position: refs/heads/master@{#35075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/js/regexp.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 8 months ago (2016-03-25 21:07:04 UTC) #1
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-03-25 21:19:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838593002/1
4 years, 8 months ago (2016-03-25 21:35:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-25 21:54:38 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-25 21:55:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fafa7635891d4d04f5003e15fa154b725ca53d0d
Cr-Commit-Position: refs/heads/master@{#35075}

Powered by Google App Engine
This is Rietveld 408576698