Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1838563003: Remove --harmony-regexps flag (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-regexps flag It's been on since M49. Also moved tests from harmony -> es6, one of which was merged with another test of the same name. While moving stuff over to regexp.js, I also noticed that there were unused calls to %FunctionSetName and %SetNativeFlag (those calls are already handled by InstallGetter()). Committed: https://crrev.com/06403470e3fe0d03f986f4c71c6dd8835d0f353c Cr-Commit-Position: refs/heads/master@{#35076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -341 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
D src/js/harmony-regexp.js View 1 chunk +0 lines, -60 lines 0 comments Download
M src/js/regexp.js View 6 chunks +33 lines, -8 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/scanner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/no-unicode-regexp-flag.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 2 chunks +53 lines, -1 line 0 comments Download
A + test/mjsunit/es6/regexp-sticky.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/regexp-flags.js View 1 chunk +0 lines, -56 lines 0 comments Download
D test/mjsunit/harmony/regexp-sticky.js View 1 chunk +0 lines, -132 lines 0 comments Download
M test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regexp-not-sticky-yet.js View 1 chunk +0 lines, -66 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-548580.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
Some cleanup I noticed while staring at --prof output.
4 years, 9 months ago (2016-03-25 21:37:53 UTC) #3
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-25 21:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838563003/1
4 years, 9 months ago (2016-03-25 22:37:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:01:17 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:02:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06403470e3fe0d03f986f4c71c6dd8835d0f353c
Cr-Commit-Position: refs/heads/master@{#35076}

Powered by Google App Engine
This is Rietveld 408576698