Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1838543002: Add test for util.byteToChar() and fix error msg. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add test for util.byteToChar() and fix error msg. Committed: https://pdfium.googlesource.com/pdfium/+/90d87793cf55f3c4e57e9db6c8de692ebef41e29

Patch Set 1 #

Patch Set 2 : Range-check, avoid wide-char output. #

Patch Set 3 : static cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -29 lines) Patch
M fpdfsdk/javascript/util.cpp View 1 2 1 chunk +11 lines, -7 lines 0 comments Download
A + testing/resources/javascript/util_bytetochar.in View 1 1 chunk +23 lines, -22 lines 0 comments Download
A testing/resources/javascript/util_bytetochar_expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Tom Sepez
Dan, PTAL.
4 years, 9 months ago (2016-03-25 19:20:19 UTC) #2
dsinclair
lgtm
4 years, 8 months ago (2016-03-28 18:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838543002/1
4 years, 8 months ago (2016-03-28 20:37:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/37)
4 years, 8 months ago (2016-03-28 20:48:26 UTC) #7
Tom Sepez
Dan, quick re-review. The handling of wide output in our sample app.alert() callback has platform ...
4 years, 8 months ago (2016-03-29 16:08:33 UTC) #8
dsinclair
lgtm
4 years, 8 months ago (2016-03-29 16:10:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838543002/40001
4 years, 8 months ago (2016-03-29 16:11:59 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:22:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/90d87793cf55f3c4e57e9db6c8de692ebef4...

Powered by Google App Engine
This is Rietveld 408576698