Renamed /shadow-all/ to /shadow/.

Renamed /shadow-all/ to /shadow/.

Reflecting shadow styling spec, 5 March 2014: ^ should be /shadow/.
c.f. http://dev.w3.org/csswg/shadow-styling/#shadow-combinator

BUG=348891
TEST=replaced all /shadow-all/ in existing layout tests with /shadow/.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169114

[dglazkov, 2014-03-06 18:35:03]

lgtm, but...

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
File Source/core/css/CSSParserValues.h (right):

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
Source/core/css/CSSParserValues.h:102: return match ? str[length()] == '\0' :
false;
We shouldn't wallpaper of what looks like a bug in WTF::equalIgnoringCase here.
Can you look into why this occurs?

[adamk, 2014-03-06 22:42:18]

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
File Source/core/css/CSSParserValues.h (right):

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
Source/core/css/CSSParserValues.h:102: return match ? str[length()] == '\0' :
false;
On 2014/03/06 18:35:03, Dimitri Glazkov wrote:
> We shouldn't wallpaper of what looks like a bug in WTF::equalIgnoringCase
here.
> Can you look into why this occurs?

Seems like you this function should just start with:

if (strlen(str) != length())
    return false;

This isn't a bug in WTF::equalIgnoringCase(), it's a big in this function
(CSSParserString::equalIgnoringCase).

[tasak, 2014-03-07 05:08:18]

Thank you for reviewing.

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
File Source/core/css/CSSParserValues.h (right):

https://codereview.chromium.org/183853035/diff/1/Source/core/css/CSSParserVal...
Source/core/css/CSSParserValues.h:102: return match ? str[length()] == '\0' :
false;
On 2014/03/06 22:42:18, adamk wrote:
> On 2014/03/06 18:35:03, Dimitri Glazkov wrote:
> > We shouldn't wallpaper of what looks like a bug in WTF::equalIgnoringCase
> here.
> > Can you look into why this occurs?
> 
> Seems like you this function should just start with:
> 
> if (strlen(str) != length())
>     return false;

Yeah. So is it ok to use strlen?

I think, strlen(str) is slower than str[length()] == '\0'.

> This isn't a bug in WTF::equalIgnoringCase(), it's a big in this function
> (CSSParserString::equalIgnoringCase).

Yeah. This is CSSParserString's bug.
It misuses WTF::equalIgnoringCase.

[esprehn, 2014-03-07 05:23:33]

On 2014/03/07 at 05:08:18, tasak wrote:
> [...]
> 
> Yeah. This is CSSParserString's bug.
> It misuses WTF::equalIgnoringCase.

Can we fix the bug in CSSParserString in a separate patch first instead of
adding this workaround?

[tasak, 2014-03-07 06:30:47]

On 2014/03/07 05:23:33, esprehn wrote:
> On 2014/03/07 at 05:08:18, tasak wrote:
> > [...]
> > 
> > Yeah. This is CSSParserString's bug.
> > It misuses WTF::equalIgnoringCase.
> 
> Can we fix the bug in CSSParserString in a separate patch first instead of
> adding this workaround?

Sure.
I have just created https://codereview.chromium.org/189843005/.

[tasak, 2014-03-11 08:58:12]

Is it ok to land this patch?

The CSSParserString issue has been already fixed (r168853).

[esprehn, 2014-03-11 09:30:24]

Lgtm

[tasak, 2014-03-13 01:53:55]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-03-13 01:54:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/183853035/20001

[commit-bot: I haz the power, 2014-03-13 05:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 05:04:51]

Failed to apply patch for
LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index:
LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
  |diff --git
a/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
b/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
  |index
5873f5203073ddb955763036d85d773d424798cf..f2a1b7b72f2b8def035a2a1f60dcb835c9cf3591
100644
  |---
a/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
  |+++
b/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:      
LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
Index: LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
diff --git
a/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
b/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
index
5873f5203073ddb955763036d85d773d424798cf..f2a1b7b72f2b8def035a2a1f60dcb835c9cf3591
100644
--- a/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
+++ b/LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt
@@ -1,4 +1,4 @@
-Test for ::content with /shadow-all/ and :host.
+Test for ::content with /shadow/ and :host.
 
 On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".

[tasak, 2014-03-13 06:35:49]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-03-13 06:35:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/183853035/60001

[commit-bot: I haz the power, 2014-03-13 07:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 07:52:17]

Try jobs failed on following builders:
  tryserver.chromium on linux_blink

[tasak, 2014-03-13 08:09:37]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-03-13 08:09:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/183853035/60001

[commit-bot: I haz the power, 2014-03-13 09:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 09:10:34]

Try jobs failed on following builders:
  tryserver.chromium on linux_blink

[tasak, 2014-03-13 09:24:03]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-03-13 09:24:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/183853035/60001

[commit-bot: I haz the power, 2014-03-13 10:35:07]

Change committed as 169114