Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183853032: [Android] Reset the set of observers when the tab is destroyed. (Closed)

Created:
6 years, 9 months ago by aruslan
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Reset the set of observers when the tab is destroyed. It's ok to remove or add the observers after the onDestroyed is received. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
aruslan1
PTAL thanks!
6 years, 9 months ago (2014-03-06 01:55:36 UTC) #1
David Trainor- moved to gerrit
lgtm
6 years, 9 months ago (2014-03-06 01:56:07 UTC) #2
aruslan1
The CQ bit was checked by aruslan@google.com
6 years, 9 months ago (2014-03-06 01:57:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/183853032/1
6 years, 9 months ago (2014-03-06 02:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/183853032/1
6 years, 9 months ago (2014-03-06 02:59:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/183853032/1
6 years, 9 months ago (2014-03-06 03:21:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:37:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 04:37:31 UTC) #8
aruslan
The CQ bit was checked by aruslan@chromium.org
6 years, 9 months ago (2014-03-06 04:56:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/183853032/1
6 years, 9 months ago (2014-03-06 04:58:04 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:02:36 UTC) #11
Message was sent while issue was closed. 
Change committed as 255331

Powered by Google App Engine
This is Rietveld 408576698