Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 183853030: [Wallpaper Picker] Cleaned UI artefacts in Surprise Me Mode. (Closed)

Created:
6 years, 9 months ago by François Beaufort
Modified:
6 years, 9 months ago
Reviewers:
bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Wallpaper Picker] Cleaned UI artefacts in Surprise Me Mode. In Surprise Me mode, changes are: - Top categories don't highlight anymore on Hover - Online Wallpaper Attributes (author + url + thumbnail) are not displayed - Selected Item Checkmark is not displayed - "Add New" button is not highlighted on Hover and don't prompt user anymore. - White Outline on thumbnails is not displayed. Screenshot: http://i.imgur.com/UPhSQZS.jpg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255379

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css View 4 chunks +8 lines, -3 lines 3 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
François Beaufort
Hello Biao, Since Surprise Me is about to be enabled by default for new Chrome ...
6 years, 9 months ago (2014-03-05 14:01:12 UTC) #1
bshe
lgtm with nit https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css File chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css (right): https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css#newcode199 chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:199: .image-picker[disabled]~.bottom-bar #online-wallpaper-attribute, nit: space instead of ...
6 years, 9 months ago (2014-03-05 19:12:23 UTC) #2
François Beaufort
https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css File chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css (right): https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css#newcode199 chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:199: .image-picker[disabled]~.bottom-bar #online-wallpaper-attribute, It is a ~ The general sibling ...
6 years, 9 months ago (2014-03-06 11:32:41 UTC) #3
bshe
lgtm https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css File chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css (right): https://codereview.chromium.org/183853030/diff/1/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css#newcode199 chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:199: .image-picker[disabled]~.bottom-bar #online-wallpaper-attribute, right, my mistake. I assumed bottom-bar ...
6 years, 9 months ago (2014-03-06 14:38:48 UTC) #4
François Beaufort
The CQ bit was checked by beaufort.francois@gmail.com
6 years, 9 months ago (2014-03-06 14:47:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/183853030/1
6 years, 9 months ago (2014-03-06 14:47:58 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 17:09:48 UTC) #7
Message was sent while issue was closed.
Change committed as 255379

Powered by Google App Engine
This is Rietveld 408576698