Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 183853026: Notification testing output should be more inclusive and consistent. (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Notification testing output should be more inclusive and consistent. This patch makes the testing output for notification layout tests more consistent with the other messages, and adds the "tag" value to the NOTIFICATION SHOWN message. "lang" should be added as well. Address a minor TODO about clearing local values as well. BUG=349015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256457

Patch Set 1 #

Patch Set 2 : Rebase + add lang() #

Patch Set 3 : Actually, let's do that later to not be blocked again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M content/shell/renderer/test_runner/notification_presenter.cc View 2 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Beverloo
This makes the output significantly cleaner, and consistent between showing and closing notifications. It also ...
6 years, 9 months ago (2014-03-04 16:29:02 UTC) #1
Andrew T Wilson (Slow)
lgtm
6 years, 9 months ago (2014-03-04 21:50:22 UTC) #2
pfeldman
rslgtm
6 years, 9 months ago (2014-03-05 15:15:23 UTC) #3
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-11 17:57:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/183853026/40001
6 years, 9 months ago (2014-03-11 18:08:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 19:38:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-11 19:38:44 UTC) #7
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-11 22:03:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/183853026/40001
6 years, 9 months ago (2014-03-11 22:33:12 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 06:42:53 UTC) #10
Message was sent while issue was closed.
Change committed as 256457

Powered by Google App Engine
This is Rietveld 408576698