Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: base/strings/string_split.cc

Issue 183853011: Move TrimWhitespace to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/strings/string_split.cc
diff --git a/base/strings/string_split.cc b/base/strings/string_split.cc
index 210789cd22d0df9b524d40aaeca002ad6e6fb705..0798562ef3b7a4421f55f9126519a5fc025f7816 100644
--- a/base/strings/string_split.cc
+++ b/base/strings/string_split.cc
@@ -23,7 +23,7 @@ static void SplitStringT(const STR& str,
if (i == c || str[i] == s) {
STR tmp(str, last, i - last);
if (trim_whitespace)
- TrimWhitespace(tmp, TRIM_ALL, &tmp);
+ base::TrimWhitespace(tmp, TRIM_ALL, &tmp);
viettrungluu 2014/02/28 23:44:14 base:: unnecessary. You're already in that namespa
// Avoid converting an empty or all-whitespace source string into a vector
// of one empty string.
if (i != c || !r->empty() || !tmp.empty())
@@ -123,13 +123,13 @@ static void SplitStringUsingSubstrT(const STR& str,
if (end_index == STR::npos) {
const STR term = str.substr(begin_index);
STR tmp;
- TrimWhitespace(term, TRIM_ALL, &tmp);
+ base::TrimWhitespace(term, TRIM_ALL, &tmp);
viettrungluu 2014/02/28 23:44:14 "
r->push_back(tmp);
return;
}
const STR term = str.substr(begin_index, end_index - begin_index);
STR tmp;
- TrimWhitespace(term, TRIM_ALL, &tmp);
+ base::TrimWhitespace(term, TRIM_ALL, &tmp);
viettrungluu 2014/02/28 23:44:14 "
r->push_back(tmp);
begin_index = end_index + s.size();
}

Powered by Google App Engine
This is Rietveld 408576698