Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 183853011: Move TrimWhitespace to the base namespace. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, chromoting-reviews_chromium.org, rpetterson, browser-components-watch_chromium.org, dcheng, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, Ilya Sherman, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, derat+watch_chromium.org, Paweł Hajdan Jr., rouslan+spellwatch_chromium.org, paulirish+reviews_chromium.org, oshima+watch_chromium.org, kalyank, ben+corewm_chromium.org, pfeldman, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, frankf, yurys, benquan, ben+ash_chromium.org, dyu1, grt+watch_chromium.org, estade+watch_chromium.org, stgao, James Su, jshin+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move TrimWhitespace to the base namespace. R=viettrungluu@chromium.org, viettrungluu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254521

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -161 lines) Patch
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/linux_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/nix/mime_util_xdg.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M base/process/process_metrics_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/strings/string_util.h View 3 chunks +11 lines, -11 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/adb_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index_types.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/hunspell_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_policy_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/required_action.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/language_detection/language_detection_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/common/feature_switch.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/host_mapping_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/ip_mapping_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/server/http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/python_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/file_chooser_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/cups_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/lib/rlz_lib.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/leveldatabase/env_chromium_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/input_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/text_elider.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/controls/styled_label.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 9 months ago (2014-02-28 23:18:52 UTC) #1
viettrungluu
LGTM w/nits. https://codereview.chromium.org/183853011/diff/1/ash/shell/app_list.cc File ash/shell/app_list.cc (right): https://codereview.chromium.org/183853011/diff/1/ash/shell/app_list.cc#newcode290 ash/shell/app_list.cc:290: base::TrimWhitespace(model_->search_box()->text(), base::TRIM_ALL, &query); I suppose it'd be ...
6 years, 9 months ago (2014-02-28 23:44:13 UTC) #2
brettw
6 years, 9 months ago (2014-03-03 19:06:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r254521.

Powered by Google App Engine
This is Rietveld 408576698