Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1838523002: Revert of Adding iOS OpenSSL Implementation (Duplicate) (Closed)

Created:
4 years, 9 months ago by svaldez
Modified:
4 years, 9 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, sdefresne+watch_chromium.org, kapishnikov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding iOS OpenSSL Implementation (patchset #23 id:420001 of https://codereview.chromium.org/1810153002/ ) Reason for revert: The tree breaks on iOS Device/Simulator due to included data files. Original issue's description: > This adds the OpenSSL-specific implementations for iOS, using SecTrustEvaluate in order to determine the validity of the certificate chain. > > BUG=591545 > > Committed: https://crrev.com/864f9468ae2a8d1ba95c64824ef2caf05b7121fc > Cr-Commit-Position: refs/heads/master@{#383297} TBR=davidben@chromium.org,rsleevi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -790 lines) Patch
M net/BUILD.gn View 3 chunks +1 line, -13 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D net/cert/cert_verify_proc_ios.h View 1 chunk +0 lines, -36 lines 0 comments Download
D net/cert/cert_verify_proc_ios.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D net/cert/x509_certificate_openssl_ios.cc View 1 chunk +0 lines, -475 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M net/net_common.gypi View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
svaldez
4 years, 9 months ago (2016-03-25 18:01:10 UTC) #1
Created Revert of Adding iOS OpenSSL Implementation

Powered by Google App Engine
This is Rietveld 408576698