Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1838483002: Create output dir in logcat printer if it doesn't exist. (Closed)

Created:
4 years, 9 months ago by bpastene
Modified:
4 years, 9 months ago
Reviewers:
jbudorick, martiniss
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create output dir in logcat printer if it doesn't exist. Also add a statement about where to find the actual logcat. BUG=597771, 448050 Committed: https://crrev.com/0c5d30d1932954a34d417bf1f195ac1428d5aeed Cr-Commit-Position: refs/heads/master@{#383330}

Patch Set 1 #

Total comments: 1

Patch Set 2 : words #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M build/android/adb_logcat_printer.py View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bpastene
ptal
4 years, 9 months ago (2016-03-25 17:21:05 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/1838483002/diff/1/build/android/adb_logcat_printer.py File build/android/adb_logcat_printer.py (right): https://codereview.chromium.org/1838483002/diff/1/build/android/adb_logcat_printer.py#newcode179 build/android/adb_logcat_printer.py:179: 'in a proceeding step. It can ...
4 years, 9 months ago (2016-03-25 17:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838483002/20001
4 years, 9 months ago (2016-03-25 17:36:04 UTC) #6
martiniss
lgtm
4 years, 9 months ago (2016-03-25 17:54:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 19:30:33 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 19:31:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c5d30d1932954a34d417bf1f195ac1428d5aeed
Cr-Commit-Position: refs/heads/master@{#383330}

Powered by Google App Engine
This is Rietveld 408576698