fix observe package to be strong mode clean

test/transformer_test.dart

Index: test/transformer_test.dart
diff --git a/test/transformer_test.dart b/test/transformer_test.dart
index 7f9b9f1bb40e89df57122c93e0e6dc24244a8bd8..1fb4bb2eb3a79259640bcbff4632f9a2ec96a2e8 100644
--- a/test/transformer_test.dart
+++ b/test/transformer_test.dart
@@ -126,21 +126,20 @@ _testInitializers(String args, String expected) {
 }
 
 /// Helper that applies the transform by creating mock assets.
-Future<String> _transform(String code) {
-  return Chain.capture(() {
+Future _transform(String code) {

[Siggi Cherem (dart-lang), 2016/03/25 17:36:29]

Doesn't matter here, but would we be able to keep String if we change should
Chain.capture to have a generic type like:

    <T> static T capture(T callback(), ... );

?

[Jennifer Messerly, 2016/03/25 18:23:23]

already filed https://github.com/dart-lang/stack_trace/issues/10 :)
but we're in code yellow. I'll take "good" over "perfect" :)

+  return Chain.capture(() async {
     var id = new AssetId('foo', 'a/b/c.dart');
     var asset = new Asset.fromString(id, code);
     var transformer = new ObservableTransformer();
-    return transformer.isPrimary(asset).then((isPrimary) {
-      expect(isPrimary, isTrue);
-      var transform = new _MockTransform(asset);
-      return transformer.apply(transform).then((_) {
-        expect(transform.outs, hasLength(2));
-        expect(transform.outs[0].id, id);
-        expect(transform.outs[1].id, id.addExtension('._buildLogs.1'));
-        return transform.outs.first.readAsString();
-      });
-    });
+    bool isPrimary = await transformer.isPrimary(asset);
+    expect(isPrimary, isTrue);
+    var transform = new _MockTransform(asset);
+    await transformer.apply(transform);

[Siggi Cherem (dart-lang), 2016/03/25 17:36:29]

is the change to use await necessary for now?

I mean, is this because we don't have union types and Future.then is
practically:

class Future<T> {
  <E> then({E | Future<E>} callback(T));
}

[Jennifer Messerly, 2016/03/25 18:23:23]

yes it is necessary & that is the reason.

FWIW -- all of my changes are to make warnings/errors/hints go away.

+
+    expect(transform.outs, hasLength(2));
+    expect(transform.outs[0].id, id);
+    expect(transform.outs[1].id, id.addExtension('._buildLogs.1'));
+    return transform.outs.first.readAsString();
   });
 }