Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1838463003: Move SkRWBuffer.h to include/ and add SK_API (Closed)

Created:
4 years, 9 months ago by scroggo_chromium
Modified:
4 years, 9 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkRWBuffer.h to include/ and add SK_API Needed for use in Blink in crrev.com/1812273003 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838463003 Committed: https://skia.googlesource.com/skia/+/77899d122083644380c833a32bd4ab5212cb0ec2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -99 lines) Patch
A + include/core/SkRWBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
D src/core/SkRWBuffer.h View 1 chunk +0 lines, -97 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo_chromium
4 years, 9 months ago (2016-03-25 18:27:41 UTC) #3
djsollen
api lgtm
4 years, 9 months ago (2016-03-25 18:38:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838463003/1
4 years, 9 months ago (2016-03-25 18:40:01 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 19:00:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/77899d122083644380c833a32bd4ab5212cb0ec2

Powered by Google App Engine
This is Rietveld 408576698