Provide GN support for cachetool and content_decoder_tool

Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080
Committed: https://crrev.com/64af64a9740a1cdcf475f7d43c8e2e2cf06c7159
Cr-Commit-Position: refs/heads/master@{#383741}

[gabadie, 2016-03-25 15:59:20]

Description was changed from

==========
Provide GN support for cachetool and content_decoder_tool

BUG=582080
==========

to

==========
Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080
==========

[gabadie, 2016-03-25 16:16:43]

gabadie@chromium.org changed reviewers:
+ davidben@chromium.org, gavinp@chromium.org, mmenke@chromium.org

[gabadie, 2016-03-25 16:16:44]

This CL provide missing GN support for cachetool and content_decoder_tool and
also make the cachetool linux only as content_decoder_tool since it is not used
anywhere else.

I also tested this change with is_component_build=true in GN.

Could one of you review it please?

[mmenke, 2016-03-25 16:53:29]

On 2016/03/25 16:16:44, gabadie wrote:
> This CL provide missing GN support for cachetool and content_decoder_tool and
> also make the cachetool linux only as content_decoder_tool since it is not
used
> anywhere else.
> 
> I also tested this change with is_component_build=true in GN.
> 
> Could one of you review it please?

I have no idea what any of those are, I guess Gavin might?

[davidben, 2016-03-25 17:19:53]

On 2016/03/25 16:53:29, mmenke wrote:
> On 2016/03/25 16:16:44, gabadie wrote:
> > This CL provide missing GN support for cachetool and content_decoder_tool
and
> > also make the cachetool linux only as content_decoder_tool since it is not
> used
> > anywhere else.
> > 
> > I also tested this change with is_component_build=true in GN.
> > 
> > Could one of you review it please?
> 
> I have no idea what any of those are, I guess Gavin might?

(Nor do I. Without context, I'm confused why this is becoming Linux-only. It
seems platform-independent.)

[pasko, 2016-03-25 17:40:57]

On 2016/03/25 17:19:53, davidben wrote:
> On 2016/03/25 16:53:29, mmenke wrote:
> > On 2016/03/25 16:16:44, gabadie wrote:
> > > This CL provide missing GN support for cachetool and content_decoder_tool
> and
> > > also make the cachetool linux only as content_decoder_tool since it is not
> > used
> > > anywhere else.
> > > 
> > > I also tested this change with is_component_build=true in GN.
> > > 
> > > Could one of you review it please?
> > 
> > I have no idea what any of those are, I guess Gavin might?
> 
> (Nor do I. Without context, I'm confused why this is becoming Linux-only. It
> seems platform-independent.)

They were failing on iOS, see: https://codereview.chromium.org/1767653002/#msg24

The tools are not really going to be useful on Android/iOS/ChrOS, and it is not
supposed to be used on Windows, so removing some conditional compilation for
windows helps readability a little.

The tools allow to read/modify a snapshot of disk_cache (both backend types),
and is going to be useful for go/loading-sandwich (oh, I should have made it
public - will do, maybe needs a little cleanup).

[pasko, 2016-03-25 17:41:39]

fwiw, yes, gavinp@ knows what those are

[gavinp, 2016-03-29 14:51:31]

lgtm.

I like going windows only; makes sense for the command line stuff.

[gabadie, 2016-03-29 15:08:31]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-03-29 15:08:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838443002/1

[commit-bot: I haz the power, 2016-03-29 16:36:50]

Description was changed from

==========
Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080
==========

to

==========
Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080
==========

[commit-bot: I haz the power, 2016-03-29 16:36:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 16:38:11]

Description was changed from

==========
Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080
==========

to

==========
Provide GN support for cachetool and content_decoder_tool

This CL also make the cachetool linux only as content_decoder_tool
since it is not used anywhere else.

BUG=582080

Committed: https://crrev.com/64af64a9740a1cdcf475f7d43c8e2e2cf06c7159
Cr-Commit-Position: refs/heads/master@{#383741}
==========

[commit-bot: I haz the power, 2016-03-29 16:38:12]

Patchset 1 (id:??) landed as
https://crrev.com/64af64a9740a1cdcf475f7d43c8e2e2cf06c7159
Cr-Commit-Position: refs/heads/master@{#383741}