Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1838433002: [cronet] Switch android_cronet_tester to static_library. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, xunjieli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cronet] Switch android_cronet_tester to static_library. BUG=597596 Committed: https://crrev.com/348a13d830f6f7e3c3f73f97c0f7f206bc3763fa Cr-Commit-Position: refs/heads/master@{#383344}

Patch Set 1 #

Total comments: 2

Patch Set 2 : xunjieli comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jbudorick
4 years, 9 months ago (2016-03-25 15:36:06 UTC) #2
xunjieli
https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl#newcode655 tools/mb/mb_config.pyl:655: # TODO(crbug/598596): Switch this back to debug_trybot when cronet's ...
4 years, 9 months ago (2016-03-25 15:38:17 UTC) #3
jbudorick
https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl#newcode655 tools/mb/mb_config.pyl:655: # TODO(crbug/598596): Switch this back to debug_trybot when cronet's ...
4 years, 9 months ago (2016-03-25 15:40:01 UTC) #4
xunjieli
On 2016/03/25 15:40:01, jbudorick wrote: > https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/1838433002/diff/1/tools/mb/mb_config.pyl#newcode655 > ...
4 years, 9 months ago (2016-03-25 15:41:52 UTC) #5
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-25 18:58:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838433002/20001
4 years, 9 months ago (2016-03-25 19:04:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 20:34:14 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 20:36:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/348a13d830f6f7e3c3f73f97c0f7f206bc3763fa
Cr-Commit-Position: refs/heads/master@{#383344}

Powered by Google App Engine
This is Rietveld 408576698