Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 18384007: Bogus assert needs to be removed on non-ia32 platforms (Closed)

Created:
7 years, 5 months ago by mvstanton
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Bogus assert needs to be removed on non-ia32 platforms BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Jakob, here are the bogus asserts that are plaguing us. Sorry to miss them ...
7 years, 5 months ago (2013-07-11 14:25:01 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-11 14:25:34 UTC) #2
mvstanton
7 years, 5 months ago (2013-07-11 14:26:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698