Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: runtime/vm/visitor.h

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/verifier.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/visitor.h
diff --git a/runtime/vm/visitor.h b/runtime/vm/visitor.h
index 9e8780b8c1951016abe06a33871b7d43c04d4811..3b071e227d62a6ebf1801015e2653c61cf53fa07 100644
--- a/runtime/vm/visitor.h
+++ b/runtime/vm/visitor.h
@@ -18,8 +18,8 @@ class RawObject;
// An object pointer visitor interface.
class ObjectPointerVisitor {
public:
- explicit ObjectPointerVisitor(Isolate* isolate) : isolate_(isolate) {}
- virtual ~ObjectPointerVisitor() {}
+ explicit ObjectPointerVisitor(Isolate* isolate) : isolate_(isolate) { }
+ virtual ~ObjectPointerVisitor() { }
Isolate* isolate() const { return isolate_; }
@@ -48,18 +48,14 @@ class ObjectPointerVisitor {
// An object visitor interface.
class ObjectVisitor {
public:
- explicit ObjectVisitor(Isolate* isolate) : isolate_(isolate) {}
+ ObjectVisitor() { }
- virtual ~ObjectVisitor() {}
-
- Isolate* isolate() const { return isolate_; }
+ virtual ~ObjectVisitor() { }
// Invoked for each object.
virtual void VisitObject(RawObject* obj) = 0;
private:
- Isolate* isolate_;
-
DISALLOW_COPY_AND_ASSIGN(ObjectVisitor);
};
@@ -67,8 +63,8 @@ class ObjectVisitor {
// An object finder visitor interface.
class FindObjectVisitor {
public:
- explicit FindObjectVisitor(Isolate* isolate) : isolate_(isolate) {}
- virtual ~FindObjectVisitor() {}
+ FindObjectVisitor() { }
+ virtual ~FindObjectVisitor() { }
// Allow to specify a address filter.
virtual uword filter_addr() const { return 0; }
@@ -81,9 +77,7 @@ class FindObjectVisitor {
virtual bool FindObject(RawObject* obj) const = 0;
private:
- Isolate* isolate_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(FindObjectVisitor);
+ DISALLOW_COPY_AND_ASSIGN(FindObjectVisitor);
};
} // namespace dart
« no previous file with comments | « runtime/vm/verifier.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698