Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: runtime/vm/service.cc

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/scavenger_test.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 499964f80262c87df966af803468bafb989758d3..0caeb9c872e8dc3efeebf044a3ed0c1de6aff079 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -3403,8 +3403,7 @@ void Service::SendExtensionEvent(Isolate* isolate,
class ContainsAddressVisitor : public FindObjectVisitor {
public:
- ContainsAddressVisitor(Isolate* isolate, uword addr)
- : FindObjectVisitor(isolate), addr_(addr) { }
+ explicit ContainsAddressVisitor(uword addr) : addr_(addr) { }
virtual ~ContainsAddressVisitor() { }
virtual uword filter_addr() const { return addr_; }
@@ -3435,7 +3434,7 @@ static RawObject* GetObjectHelper(Thread* thread, uword addr) {
{
NoSafepointScope no_safepoint;
Isolate* isolate = thread->isolate();
- ContainsAddressVisitor visitor(isolate, addr);
+ ContainsAddressVisitor visitor(addr);
object = isolate->heap()->FindObject(&visitor);
}
@@ -3445,7 +3444,7 @@ static RawObject* GetObjectHelper(Thread* thread, uword addr) {
{
NoSafepointScope no_safepoint;
- ContainsAddressVisitor visitor(Dart::vm_isolate(), addr);
+ ContainsAddressVisitor visitor(addr);
object = Dart::vm_isolate()->heap()->FindObject(&visitor);
}
« no previous file with comments | « runtime/vm/scavenger_test.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698