Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: runtime/vm/disassembler.cc

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/heap_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/disassembler.h" 5 #include "vm/disassembler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/deopt_instructions.h" 8 #include "vm/deopt_instructions.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/il_printer.h" 10 #include "vm/il_printer.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 jsarr_.AddValueNull(); 92 jsarr_.AddValueNull();
93 jsarr_.AddValueNull(); 93 jsarr_.AddValueNull();
94 jsarr_.AddValue(p); 94 jsarr_.AddValue(p);
95 jsarr_.AddValueNull(); 95 jsarr_.AddValueNull();
96 free(p); 96 free(p);
97 } 97 }
98 98
99 99
100 class FindAddrVisitor : public FindObjectVisitor { 100 class FindAddrVisitor : public FindObjectVisitor {
101 public: 101 public:
102 explicit FindAddrVisitor(uword addr) 102 explicit FindAddrVisitor(uword addr) : addr_(addr) { }
103 : FindObjectVisitor(Isolate::Current()), addr_(addr) { }
104 virtual ~FindAddrVisitor() { } 103 virtual ~FindAddrVisitor() { }
105 104
106 virtual uword filter_addr() const { return addr_; } 105 virtual uword filter_addr() const { return addr_; }
107 106
108 // Check if object matches find condition. 107 // Check if object matches find condition.
109 virtual bool FindObject(RawObject* obj) const { 108 virtual bool FindObject(RawObject* obj) const {
110 return obj == reinterpret_cast<RawObject*>(addr_); 109 return obj == reinterpret_cast<RawObject*>(addr_);
111 } 110 }
112 111
113 private: 112 private:
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 THR_Print("}\n"); 324 THR_Print("}\n");
326 } 325 }
327 if (optimized && FLAG_trace_inlining_intervals) { 326 if (optimized && FLAG_trace_inlining_intervals) {
328 code.DumpInlinedIntervals(); 327 code.DumpInlinedIntervals();
329 } 328 }
330 } 329 }
331 330
332 #endif // !PRODUCT 331 #endif // !PRODUCT
333 332
334 } // namespace dart 333 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/heap_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698