Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1838343003: ash: Initialize some pointers to null in SystemTray constructor (Closed)

Created:
4 years, 8 months ago by James Cook
Modified:
4 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Initialize some pointers to null in SystemTray constructor They eventually get valid pointers assigned, but this makes the code clearer and prevents spurious warnings from editors (like Eclipse) that detect constructors with uninitialized data. BUG=none TEST=existing ash tests Committed: https://crrev.com/56f5830b7edd6ea938f70406edcb4e7d03baacad Cr-Commit-Position: refs/heads/master@{#383891}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ash/system/tray/system_tray.cc View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
James Cook
Steven, PTAL
4 years, 8 months ago (2016-03-30 00:11:08 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/1838343003/diff/1/ash/system/tray/system_tray.cc File ash/system/tray/system_tray.cc (right): https://codereview.chromium.org/1838343003/diff/1/ash/system/tray/system_tray.cc#newcode141 ash/system/tray/system_tray.cc:141: screen_share_tray_item_(nullptr) { Bleh. These probably shouldn't exist, but ...
4 years, 8 months ago (2016-03-30 00:47:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838343003/1
4 years, 8 months ago (2016-03-30 01:16:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 01:23:10 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:25:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56f5830b7edd6ea938f70406edcb4e7d03baacad
Cr-Commit-Position: refs/heads/master@{#383891}

Powered by Google App Engine
This is Rietveld 408576698