Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8528)

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.h

Issue 1838333004: Add a notice about other forms of browsing history to the History WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desktop-ui-after-rebase
Patch Set: Moved build dependencies to OS!=iOS Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/browsing_history_handler.h
diff --git a/chrome/browser/ui/webui/browsing_history_handler.h b/chrome/browser/ui/webui/browsing_history_handler.h
index f94ef2fa129bb6676e5f6cec4d699f7991922723..da9e800ae8f29377b69c8713c64923ea7e0d55ae 100644
--- a/chrome/browser/ui/webui/browsing_history_handler.h
+++ b/chrome/browser/ui/webui/browsing_history_handler.h
@@ -162,6 +162,11 @@ class BrowsingHistoryHandler : public content::WebUIMessageHandler,
history::WebHistoryService::Request* request,
const base::DictionaryValue* results_value);
+ // Callback telling us whether other forms of browsing history were found
+ // on the history server.
+ void OtherFormsOfBrowsingHistoryQueryComplete(
+ bool foundOtherFormsOfBrowsingHistory);
Dan Beam 2016/03/31 01:05:44 cpp_vars_like_this
msramek 2016/03/31 19:20:02 Done. Yep, switching between C++ and Java...
+
// Callback from the history system when visits were deleted.
void RemoveComplete();
@@ -218,6 +223,12 @@ class BrowsingHistoryHandler : public content::WebUIMessageHandler,
ScopedObserver<history::HistoryService, history::HistoryServiceObserver>
history_service_observer_;
+ // Whether the last call to Web History returned synced results.
+ bool has_synced_results_;
+
+ // Whether there are other forms of browsing history on the history server.
+ bool has_other_forms_of_browsing_history_;
+
base::WeakPtrFactory<BrowsingHistoryHandler> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(BrowsingHistoryHandler);

Powered by Google App Engine
This is Rietveld 408576698