Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/resources/md_history/history.js

Issue 1838333004: Add a notice about other forms of browsing history to the History WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desktop-ui-after-rebase
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history.js
diff --git a/chrome/browser/resources/md_history/history.js b/chrome/browser/resources/md_history/history.js
index f67c06bd00055627a6038d828b1f63f84ea9ca73..b3678e8ecfc0ccdc9f990b594e6446f824262551 100644
--- a/chrome/browser/resources/md_history/history.js
+++ b/chrome/browser/resources/md_history/history.js
@@ -100,6 +100,19 @@ function historyResult(info, results) {
}
/**
+ * Called by the history backend after receiving results and after discovering
+ * the existence of other forms of browsing history.
+ * @param {boolean} hasSyncedResults Whether there are synced results.
+ * @param {boolean} includeOtherFormsOfBrowsingHistory Whether to include
+ * a sentence about the existence of other forms of browsing history.
+ */
+function showNotification(
+ hasSyncedResults, includeOtherFormsOfBrowsingHistory) {
+ // TODO(msramek): Implement the joint notification about web history and other
+ // forms of browsing history for the MD history page.
+}
+
+/**
* Receives the synced history data. An empty list means that either there are
* no foreign sessions, or tab sync is disabled for this profile.
* |isTabSyncEnabled| makes it possible to distinguish between the cases.
« no previous file with comments | « chrome/browser/resources/history/history_mobile.css ('k') | chrome/browser/ui/webui/browsing_history_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698