Source/platform/graphics/GraphicsLayer.h - Issue 183833020: Re-land "Drop background color optimization for composited layers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/GraphicsLayer.h

Issue 183833020: Re-land "Drop background color optimization for composited layers" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: more succinct if statement Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/compositing/CompositedLayerMapping.cpp ('K') | « Source/core/rendering/compositing/CompositedLayerMapping.cpp ('k') | Source/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/GraphicsLayer.h

diff --git a/Source/platform/graphics/GraphicsLayer.h b/Source/platform/graphics/GraphicsLayer.h

index 0bb507d46296f89500b6954fe0ece73102e375ae..1e2273efce4a6b0b0092141aa5f068be6b79522c 100644

--- a/Source/platform/graphics/GraphicsLayer.h

+++ b/Source/platform/graphics/GraphicsLayer.h

@@ -232,7 +232,6 @@ public:

// Layer contents

void setContentsToImage(Image*);

void setContentsToNinePatch(Image*, const IntRect& aperture);

- void setContentsToSolidColor(const Color&);

void setContentsToPlatformLayer(blink::WebLayer* layer) { setContentsTo(layer); }

bool hasContentsLayer() const { return m_contentsLayer; }

@@ -382,8 +381,6 @@ private:

OwnPtr<blink::WebContentLayer> m_layer;

OwnPtr<blink::WebImageLayer> m_imageLayer;

OwnPtr<blink::WebNinePatchLayer> m_ninePatchLayer;

- Color m_contentsSolidColor;

- OwnPtr<blink::WebSolidColorLayer> m_solidColorLayer;

blink::WebLayer* m_contentsLayer;

// We don't have ownership of m_contentsLayer, but we do want to know if a given layer is the

// same as our current layer in setContentsTo(). Since m_contentsLayer may be deleted at this point,