Issue 183833017: Oilpan: Fix the CSSKeyframesRule destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183833017: Oilpan: Fix the CSSKeyframesRule destructor. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)

Modified:
6 years, 9 months ago

Reviewers:
haraken, wibling-chromium, kouhei (in TOK)

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, oilpan-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Oilpan: Fix the CSSKeyframesRule destructor. The m_childRuleCSSOMWrappers vector is in the heap and we should not touch it. Not even to get its size. R=haraken@chromium.org, kouhei@chromium.org, wibling@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168373

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/core/css/CSSKeyframesRule.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183833017/1

6 years, 9 months ago (2014-03-04 07:34:48 UTC) #5

Mads Ager (chromium)

The CQ bit was unchecked by ager@chromium.org

6 years, 9 months ago (2014-03-04 09:37:07 UTC) #7

Mads Ager (chromium)

6 years, 9 months ago (2014-03-04 10:01:17 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 manually as r168373 (presubmit successful).