Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 183833016: Add some incremental compositing tests (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chrishtr, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

Add some incremental compositing tests These tests that compositing updates work even when the render tree changes in a minor way. These tests would have failed when introducing dirty bits for CompositedLayerMapping in https://codereview.chromium.org/183763016. R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168358

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Reupload #

Total comments: 7

Patch Set 4 : Now with ref tests #

Total comments: 2

Patch Set 5 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -0 lines) Patch
A LayoutTests/compositing/squashing/visibility-composited-squashing.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/compositing/visibility/visibility-composited-incremental-update.html View 1 2 3 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/compositing/visibility/visibility-composited-incremental-update-expected.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-03 21:15:27 UTC) #1
chrishtr
https://codereview.chromium.org/183833016/diff/40001/LayoutTests/compositing/squashing/visibility-composited-squashing.html File LayoutTests/compositing/squashing/visibility-composited-squashing.html (right): https://codereview.chromium.org/183833016/diff/40001/LayoutTests/compositing/squashing/visibility-composited-squashing.html#newcode1 LayoutTests/compositing/squashing/visibility-composited-squashing.html:1: <!DOCTYPE html> Include <script src="../../resources/js-test.js"></script> so that it doesn't ...
6 years, 9 months ago (2014-03-03 21:40:31 UTC) #2
abarth-chromium
https://codereview.chromium.org/183833016/diff/40001/LayoutTests/compositing/squashing/visibility-composited-squashing.html File LayoutTests/compositing/squashing/visibility-composited-squashing.html (right): https://codereview.chromium.org/183833016/diff/40001/LayoutTests/compositing/squashing/visibility-composited-squashing.html#newcode1 LayoutTests/compositing/squashing/visibility-composited-squashing.html:1: <!DOCTYPE html> On 2014/03/03 21:40:32, chrishtr wrote: > Include ...
6 years, 9 months ago (2014-03-03 22:01:30 UTC) #3
chrishtr
lgtm https://codereview.chromium.org/183833016/diff/50001/LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html File LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html (right): https://codereview.chromium.org/183833016/diff/50001/LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html#newcode38 LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html:38: <div id="target2" class="squashed ehidden" style="top: 4px"></div> ehidden? I ...
6 years, 9 months ago (2014-03-03 22:50:57 UTC) #4
abarth-chromium
https://codereview.chromium.org/183833016/diff/50001/LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html File LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html (right): https://codereview.chromium.org/183833016/diff/50001/LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html#newcode38 LayoutTests/compositing/squashing/visibility-composited-squashing-expected.html:38: <div id="target2" class="squashed ehidden" style="top: 4px"></div> On 2014/03/03 22:50:57, ...
6 years, 9 months ago (2014-03-03 22:57:04 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-03 22:58:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/183833016/70001
6 years, 9 months ago (2014-03-03 22:58:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/183833016/70001
6 years, 9 months ago (2014-03-03 23:23:35 UTC) #8
abarth-chromium
6 years, 9 months ago (2014-03-04 04:44:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 manually as r168358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698