Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: trunk/src/build/gyp_chromium

Issue 183833015: Revert 254427 "Add free space print to see how near edge bots are" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/gyp_chromium
===================================================================
--- trunk/src/build/gyp_chromium (revision 254545)
+++ trunk/src/build/gyp_chromium (working copy)
@@ -7,7 +7,6 @@
# This script is wrapper for Chromium that adds some support for how GYP
# is invoked by Chromium beyond what can be done in the gclient hooks.
-import ctypes
import glob
import gyp_helper
import json
@@ -394,14 +393,6 @@
copy_runtime(out_release_nacl64, x64, 'msvc%s120.dll')
-def GetFreeSpaceMBWindows(path):
- """Returns the number of mebibytes free for a given directory."""
- free_bytes = ctypes.c_ulonglong(0)
- ctypes.windll.kernel32.GetDiskFreeSpaceExW(
- ctypes.c_wchar_p(path), None, None, ctypes.pointer(free_bytes))
- return free_bytes.value / 1024 / 1024
-
-
if __name__ == '__main__':
args = sys.argv[1:]
@@ -525,12 +516,8 @@
# Include the VS runtime in the PATH in case it's not machine-installed.
runtime_path = ';'.join(vs2013_runtime_dll_dirs)
os.environ['PATH'] = runtime_path + ';' + os.environ['PATH']
- # TODO(scottmg): Temporarily add free space print to try to see how close
- # we're getting to failures on windows bots. http://crbug.com/348350
- print('Using automatic toolchain in %s (%s edition), free space: %dM.' % (
- toolchain,
- 'Pro' if version_is_pro else 'Express',
- GetFreeSpaceMBWindows(GetOutputDirectory())))
+ print('Using automatic toolchain in %s (%s edition).' % (
+ toolchain, 'Pro' if version_is_pro else 'Express'))
# If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
# to enfore syntax checking.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698