Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183833011: SkBitmap::Config is deprecated, switch to using SkColorType (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

SkBitmap::Config is deprecated, switch to using SkColorType BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
reed1
6 years, 9 months ago (2014-03-03 14:58:41 UTC) #1
f(malita)
lgtm
6 years, 9 months ago (2014-03-03 15:01:40 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-03 15:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/183833011/1
6 years, 9 months ago (2014-03-03 15:02:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:01:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24778
6 years, 9 months ago (2014-03-03 20:01:58 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-04 02:25:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/183833011/1
6 years, 9 months ago (2014-03-04 02:25:26 UTC) #8
reed1
Are the win failures attributable to this CL?
6 years, 9 months ago (2014-03-04 15:47:42 UTC) #9
f(malita)
On 2014/03/04 15:47:42, reed1 wrote: > Are the win failures attributable to this CL? Most ...
6 years, 9 months ago (2014-03-04 15:50:49 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 18:06:48 UTC) #11
commit-bot: I haz the power
List of reviewers changed. robertphillips@google.com did a drive-by without LGTM'ing!
6 years, 9 months ago (2014-03-05 18:06:48 UTC) #12
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 9 months ago (2014-03-05 18:08:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/183833011/1
6 years, 9 months ago (2014-03-05 18:09:16 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 18:09:47 UTC) #15
Message was sent while issue was closed. 
Change committed as 168504

Powered by Google App Engine
This is Rietveld 408576698