sdk/lib/_internal/compiler/implementation/source_file_provider.dart - Issue 183833010: Change --hide-package-warnings to --show-package-warnings and add hint on suppress warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

Issue 183833010: Change --hide-package-warnings to --show-package-warnings and add hint on suppress warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/source_file.dart ('K') | « sdk/lib/_internal/compiler/implementation/source_file.dart ('k') | sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

diff --git a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

index c97cebe3cf0d2494301b328f38de5ae5997fe188..861bc2e58fb80e7db1c370710979a3e427a34399 100644

--- a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

+++ b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

@@ -151,14 +151,14 @@ class FormattingDiagnosticHandler {

color = (x) => x;

}

if (uri == null) {

- assert(fatal);

- print(color(message));

+ print('${color(message)}');

} else {

SourceFile file = provider.sourceFiles[uri.toString()];

- if (file == null) {

+ if (file != null) {

+ print(file.getLocationMessage(color(message), begin, end, true, color));

+ } else {

throw '$uri: file is null';

}

- print(file.getLocationMessage(color(message), begin, end, true, color));

}

if (fatal && throwOnError) {

isAborting = true;