chrome_elf/create_file/chrome_create_file_unittest.cc - Issue 183833004: Make chrome_elf use thunks instead of function pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/create_file/chrome_create_file_unittest.cc

Issue 183833004: Make chrome_elf use thunks instead of function pointers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move all memory mgmt out of CopyThunk Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_elf/create_file/chrome_create_file_unittest.cc

diff --git a/chrome_elf/create_file/chrome_create_file_unittest.cc b/chrome_elf/create_file/chrome_create_file_unittest.cc

index e25b159fcbe9bd554d3c98cc880735e793a4f174..e958aa96e05fded8f387cdaa441acf6ac2e3ec06 100644

--- a/chrome_elf/create_file/chrome_create_file_unittest.cc

+++ b/chrome_elf/create_file/chrome_create_file_unittest.cc

@@ -377,9 +377,7 @@ TEST_F(ChromeCreateFileTest, BypassTest) {

}

TEST_F(ChromeCreateFileTest, NtCreateFileAddressCheck) {

- HMODULE ntdll_handle = ::GetModuleHandle(L"ntdll.dll");

- EXPECT_EQ(::GetProcAddress(ntdll_handle, "NtCreateFile"),

- g_ntdll_lookup["NtCreateFile"]);

+ EXPECT_EQ(&g_nt_thunk_storage, g_ntdll_lookup["NtCreateFile"]);

}

TEST_F(ChromeCreateFileTest, ReadWriteFromNtDll) {