Make chrome_elf use thunks instead of function pointers.

sandbox/win/src/service_resolver.h

Index: sandbox/win/src/service_resolver.h
diff --git a/sandbox/win/src/service_resolver.h b/sandbox/win/src/service_resolver.h
index 00896922049ad45b569a111f97384cb97f57782b..f2e8e0e2083da24d90cedf8ff7bf7597edd2011c 100644
--- a/sandbox/win/src/service_resolver.h
+++ b/sandbox/win/src/service_resolver.h
@@ -46,6 +46,15 @@ class ServiceResolverThunk : public ResolverThunk {
   // Call this to set up ntdll_base_ which will allow for local patches.
   virtual void AllowLocalPatches();
 
+  // Verify that the function specified by |target_name| in |target_module| is a
+  // service and copy the first |storage_bytes| of data from that function into

[rvargas (doing something else), 2014/03/04 19:11:35]

nit: I think the implementation is correct, but this comment is not completely
aligned with reality, as the function fails if storage_bytes is too small
(unfortunately, there's no public way of getting the minimum size).

Maybe replace the last part with something like "and copies that function into
|thunk_storage|"

BTW, verify->verifies.

[Cait (Slow), 2014/03/04 20:36:05]

Done.

+  // |thunk_storage|.
+  virtual NTSTATUS CopyThunk(const void* target_module,
+                             const char* target_name,
+                             BYTE* thunk_storage,
+                             size_t storage_bytes,
+                             size_t* storage_used);
+
  protected:
   // The unit test will use this member to allow local patch on a buffer.
   HMODULE ntdll_base_;