Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1838323002: Move make_scoped_ptr into //base/memory/ptr_util.h. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move make_scoped_ptr into //base/memory/ptr_util.h. Preparatory CL for renaming scoped_ptr to std::unique_ptr. One of the changes is replacing all uses of make_scoped_ptr() with WrapUnique(), which lives in a separate header. In order to incrementally update files to use the new header, this CL moves make_scoped_ptr to ptr_util.h but still includes it in scoped_ptr.h to avoid breaking the build during the transition. BUG=554298 Committed: https://crrev.com/e180e0b92e020144eb62530e561c9579cb0f35a7 Cr-Commit-Position: refs/heads/master@{#383815}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M base/memory/ptr_util.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 8 months ago (2016-03-29 18:54:34 UTC) #2
danakj
LGTM https://codereview.chromium.org/1838323002/diff/1/base/memory/ptr_util.h File base/memory/ptr_util.h (right): https://codereview.chromium.org/1838323002/diff/1/base/memory/ptr_util.h#newcode12 base/memory/ptr_util.h:12: // for scoped_ptr<FooBarBaz<type> >(new FooBarBaz<type>(arg)) drop the extra ...
4 years, 8 months ago (2016-03-29 18:58:53 UTC) #3
dcheng
https://codereview.chromium.org/1838323002/diff/1/base/memory/ptr_util.h File base/memory/ptr_util.h (right): https://codereview.chromium.org/1838323002/diff/1/base/memory/ptr_util.h#newcode12 base/memory/ptr_util.h:12: // for scoped_ptr<FooBarBaz<type> >(new FooBarBaz<type>(arg)) On 2016/03/29 at 18:58:53, ...
4 years, 8 months ago (2016-03-29 19:00:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838323002/20001
4 years, 8 months ago (2016-03-29 19:01:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 20:51:24 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e180e0b92e020144eb62530e561c9579cb0f35a7 Cr-Commit-Position: refs/heads/master@{#383815}
4 years, 8 months ago (2016-03-29 20:53:34 UTC) #10
dcheng
4 years, 8 months ago (2016-04-01 03:54:09 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1845243004/ by dcheng@chromium.org.

The reason for reverting is: No longer needed given the updated migration plan..

Powered by Google App Engine
This is Rietveld 408576698