Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: common/gcloud/pubsub/subscriber/source.go

Issue 1838303002: Use native Pub/Sub library primitives. (Closed) Base URL: https://github.com/luci/luci-go@logdog-go1.6
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/gcloud/pubsub/subscriber/source.go
diff --git a/common/gcloud/pubsub/subscriber/source.go b/common/gcloud/pubsub/subscriber/source.go
deleted file mode 100644
index 6bb4020c7d69275310a007f31bfde632171a5347..0000000000000000000000000000000000000000
--- a/common/gcloud/pubsub/subscriber/source.go
+++ /dev/null
@@ -1,43 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package subscriber
-
-import (
- "github.com/luci/luci-go/common/gcloud/pubsub"
- "golang.org/x/net/context"
-)
-
-// Source is used to pull Pub/Sub messages in batches.
-type Source interface {
- // Pull retrieves a new batch of Pub/Sub messages to process.
- Pull(context.Context) ([]*pubsub.Message, error)
-}
-
-// PubSubSource is a Source implementation built on top of a pubsub.PubSub.
-type pubSubSource struct {
- ps pubsub.Connection
- sub pubsub.Subscription
- batch int
-}
-
-// NewSource generates a new Source by wrapping a pubsub.Connection
-// implementation. This Source is bound to a single subscription.
-//
-// If the supplied batch size is <= 0, the maximum allowed Pub/Sub batch size
-// will be used.
-func NewSource(ps pubsub.Connection, s pubsub.Subscription, batch int) Source {
- if batch <= 0 {
- batch = pubsub.MaxSubscriptionPullSize
- }
- return &pubSubSource{
- ps: ps,
- sub: s,
- batch: batch,
- }
-}
-
-func (s *pubSubSource) Pull(c context.Context) (msgs []*pubsub.Message, err error) {
- return s.ps.Pull(c, s.sub, s.batch)
-}

Powered by Google App Engine
This is Rietveld 408576698