Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18383003: Move DeleteAfterReboot and Move to base namespace (Closed)

Created:
7 years, 5 months ago by brettw
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik+watch_chromium.org, amit, dcheng, kinuko+watch, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, oshima+watch_chromium.org, Lei Zhang, tfarina, tommycli, robertshield, Greg Billock, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move DeleteAfterReboot, Move, and ReplaceFile to base namespace Rename ReplaceFileAndGetError (only used once) to ReplaceFile (used 5 times) and have each of those callers specify NULL for the output error if they don't care. Remove InsertBeforeExtension from file_util.cc which seems to be unused. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209532

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -185 lines) Patch
M base/file_util.h View 1 3 chunks +12 lines, -17 lines 0 comments Download
M base/file_util.cc View 2 chunks +6 lines, -31 lines 0 comments Download
M base/file_util_posix.cc View 6 chunks +42 lines, -41 lines 0 comments Download
M base/file_util_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 5 chunks +18 lines, -16 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/files/file_util_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/crash_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_patcher_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/test_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_backend.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/storage_monitor/image_capture_device.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/move_tree_work_item.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/dll_redirector_loading_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/common/win/install_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/cache_util_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/memory_watcher/memory_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=jam
7 years, 5 months ago (2013-07-01 20:09:38 UTC) #1
brettw
7 years, 5 months ago (2013-07-01 23:07:44 UTC) #2
Message was sent while issue was closed. 
Committed patchset #4 manually as r209532.

Powered by Google App Engine
This is Rietveld 408576698