chrome/chrome_browser_ui.gypi - Issue 1838273003: MD Settings: Hooking up native certificate manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1838273003: MD Settings: Hooking up native certificate manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify ifdefs per feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/native_certificates_handler.cc ('K') | « chrome/browser/ui/webui/settings/native_certificates_handler.cc ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 597da2e15b3fd84ab110d77e55e7c0a1596c2dbb..861d099eb80fb494fc009fef568630c0b900a88f 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -2811,6 +2811,10 @@

'browser/ui/webui/settings/certificates_handler.cc',

'browser/ui/webui/settings/certificates_handler.h',

+ 'chrome_browser_ui_non_nss_sources': [

Dan Beam 2016/03/31 00:20:57 nit: chrome_browser_ui_native_certificates_sources

dpapad 2016/03/31 01:15:03 I prefer the "non_nss_sources" over "native_certif

+ 'browser/ui/webui/settings/native_certificates_handler.cc',

+ 'browser/ui/webui/settings/native_certificates_handler.h',

+ ],

'chrome_browser_ui_omnibox_non_mobile_sources': [

'browser/ui/omnibox/alternate_nav_infobar_delegate.cc',

'browser/ui/omnibox/alternate_nav_infobar_delegate.h',

@@ -3128,6 +3132,9 @@

['use_nss_certs==1', {

'sources': [ '<@(chrome_browser_ui_nss_sources)' ],

}],

+ ['use_nss_certs==0 and (OS=="win" or OS=="mac")', {

+ 'sources': [ '<@(chrome_browser_ui_non_nss_sources)' ],

+ }],

['enable_themes==0', {

'sources!': [

'browser/ui/webui/theme_source.cc',