chrome/browser/ui/BUILD.gn - Issue 1838273003: MD Settings: Hooking up native certificate manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 1838273003: MD Settings: Hooking up native certificate manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify ifdefs per feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_resources.grd ('K') | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | chrome/browser/ui/webui/settings/native_certificates_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 9b6799e92eb0dd98c911dd4012e9b066bf866518..5a81f50c93308e16c8827c59b4f7db212ba4dbdc 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -366,6 +366,12 @@ source_set("ui") {

if (use_nss_certs) {

sources +=

rebase_path(gypi_values.chrome_browser_ui_nss_sources, ".", "//chrome")

+ } else {

+ if (is_mac || is_win) {

+ sources += rebase_path(gypi_values.chrome_browser_ui_non_nss_sources,

+ ".",

+ "//chrome")

+ }

}

Dan Beam 2016/03/31 00:20:57 nit: if (use_nss_certs) { ... } if (is_mac || i

dpapad 2016/03/31 01:15:03 Done.

if (!enable_themes) {

sources -= [ "webui/theme_source.cc" ]