Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1838233002: UsbChooserDialogAndroid::Select should return when guid is found (Closed)

Created:
4 years, 8 months ago by juncai
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UsbChooserDialogAndroid::Select should return when guid is found At UsbChooserDialogAndroid::Select, when guid is found in the for loop, the function should return, no need to continue the for loop. BUG=591735 Committed: https://crrev.com/1004ae2da751e390402d4a7228bb8132121de167 Cr-Commit-Position: refs/heads/master@{#383762}

Patch Set 1 : UsbChooserDialogAndroid::Select should return when guid is found #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
juncai
Please take a look.
4 years, 8 months ago (2016-03-29 17:14:42 UTC) #2
Yaron
lgtm
4 years, 8 months ago (2016-03-29 17:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838233002/1
4 years, 8 months ago (2016-03-29 17:35:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 17:51:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:53:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1004ae2da751e390402d4a7228bb8132121de167
Cr-Commit-Position: refs/heads/master@{#383762}

Powered by Google App Engine
This is Rietveld 408576698