Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4771)

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_category.js

Issue 1838213002: Simplify Site Settings tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_settings_category.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_category.js b/chrome/browser/resources/settings/site_settings/site_settings_category.js
index 8060099dc44d06e23f3e0a462b3b571211beded1..fa3bc924e74bd96c5cbaa619d713bdb5f38e45d5 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_category.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_category.js
@@ -2,12 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Define a global boolean for notifications (only enabled in the test class).
-cr.exportPath('settings_test');
-
-/** @type {boolean} */
-settings_test.siteCategoryNotifyForTest;
-
/**
* @fileoverview
* 'site-settings-category' is the polymer element for showing a certain
@@ -32,10 +26,7 @@ Polymer({
* example, the Location category can be set to Block/Ask so false, in that
* case, represents Block and true represents Ask.
*/
- categoryEnabled: {
- type: Boolean,
- notify: true, // !!settings_test.siteCategoryNotifyForTest,
- },
+ categoryEnabled: Boolean,
/**
* The site that was selected by the user in the dropdown list.
@@ -115,7 +106,7 @@ Polymer({
settings.PermissionValues.ASK);
break;
default:
- assertNotReached();
+ assertNotReached('Invalid category: ' + this.category);
}
},

Powered by Google App Engine
This is Rietveld 408576698