chrome/browser/resources/settings/site_settings/site_details_permission.js - Issue 1838213002: Simplify Site Settings tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.js

Issue 1838213002: Simplify Site Settings tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/constants.js ('k') | chrome/browser/resources/settings/site_settings/site_list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details_permission.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js

index 423ced58da2b678cf875cf8d2d2a22c33b2ca680..b2f4ce64725c50885d8ce6af5f0a8f42729688b2 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js

@@ -53,8 +53,8 @@ Polymer({

for (var i = 0; i < exceptionList.length; ++i) {

if (exceptionList[i].origin == site.origin) {

// TODO(finnur): Convert to use attrForSelected.

- this.$.permission.selected =

- exceptionList[i].setting == 'allow' ? 0 : 1;

+ this.$.permission.selected = exceptionList[i].setting ==

+ settings.PermissionStringValues.ALLOW ? 0 : 1;

this.$.details.hidden = false;

}