chrome/browser/resources/settings/site_settings/site_settings_category.js - Issue 1838213002: Simplify Site Settings tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_category.js

Issue 1838213002: Simplify Site Settings tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_list.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_category.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_category.js b/chrome/browser/resources/settings/site_settings/site_settings_category.js

index 8060099dc44d06e23f3e0a462b3b571211beded1..54b6879944786fc946ce5feb77bde796594a6e22 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_category.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_category.js

@@ -2,12 +2,6 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// Define a global boolean for notifications (only enabled in the test class).

-cr.exportPath('settings_test');

-/** @type {boolean} */

-settings_test.siteCategoryNotifyForTest;

/**

* @fileoverview

* 'site-settings-category' is the polymer element for showing a certain

@@ -34,7 +28,6 @@ Polymer({

categoryEnabled: {

dpapad 2016/03/29 21:46:33 Nit (optional): You can shorten this now. categor

Finnur 2016/03/30 11:22:43 Done.

type: Boolean,

- notify: true, // !!settings_test.siteCategoryNotifyForTest,

/**