Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1838203003: [TO M50] Enable implicit signalling for HE AAC v1 & v2 in ADTS. (Closed)

Created:
4 years, 8 months ago by chcunningham
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[TO M50] Enable implicit signalling for HE AAC v1 & v2 in ADTS. This allows MSE to playback HE AAC v1 (Spectral Band Replication) and v2 (Parametric Stereo) in the ADTS (.acc) container. ADTS is not capable of explicitly signaling these profiles, so the frame's metadata will claim the stream is an earlier profile (e.g AAC LC) and the decoder will later tell us its actually HE AAC. See For more background, see these sections of 2009 ISO-14496-3 1.6.5.2 Implicit and explicit signaling of SBR 1.6.6.2 Implicit and Explicit Signaling of Parametric Stereo TEST=new media unit tests and all manual tests in bug report BUG=534301, 177872 Review URL: https://codereview.chromium.org/1805013003 Cr-Commit-Position: refs/heads/master@{#383478} (cherry picked from commit 8a400694209ce5d56e013673f8c9e8a2b0a1017c) TBR=dalecurtis@chromium.org, ccameron@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8c2780f4c3ffb9bcae756e9d8e761bd85bf9c4b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -43 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_buffer.h View 2 chunks +7 lines, -1 line 0 comments Download
M media/base/audio_buffer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 3 chunks +49 lines, -16 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 5 chunks +63 lines, -9 lines 0 comments Download
A media/test/data/bear-audio-implicit-he-aac-v1.aac View Binary file 0 comments Download
A media/test/data/bear-audio-implicit-he-aac-v2.aac View Binary file 0 comments Download
A media/test/data/bear-audio-lc-aac.aac View Binary file 0 comments Download
A media/test/data/bear-audio-main-aac.aac View Binary file 0 comments Download
M media/test/pipeline_integration_test.cc View 7 chunks +105 lines, -16 lines 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
chcunningham
4 years, 8 months ago (2016-03-29 21:28:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c2780f4c3ffb9bcae756e9d8e761bd85bf9c4b6.

Powered by Google App Engine
This is Rietveld 408576698