Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html

Issue 1838183003: Fix problems on changing 'multiple' state SELECT element to 'single' state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a typo in a comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html b/third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html
index 60bd8c048e3d4a8186f60cc02d4a47e9ec04e132..0e7f0de72e04a5e99b3db2731bd715267c5f768d 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection.html
@@ -8,9 +8,9 @@ function go() {
selectElement = document.getElementsByTagName('select')[0];
shouldBe("selectElement.selectedIndex", "-1");
- // Preserve selection on conversion.
+ // Do not preserve non-selected state on conversion to single.
selectElement.multiple = false;
- shouldBe("selectElement.selectedIndex", "-1");
+ shouldBe("selectElement.selectedIndex", "0");
// <select multiple="false"> should have a selection by default and that
// selection should be preserved.
@@ -24,7 +24,7 @@ function go() {
selectElement.style.display = '';
shouldBe("selectElement.selectedIndex", "-1");
selectElement.multiple = false;
- shouldBe("selectElement.selectedIndex", "-1");
+ shouldBe("selectElement.selectedIndex", "0");
selectElement = document.getElementsByTagName('select')[3];
selectElement.style.display = '';
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/select/change-multiple-preserve-selection-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698