Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1838183003: Fix problems on changing 'multiple' state SELECT element to 'single' state. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix problems on changing 'multiple' state SELECT element to 'single' state. This CL fixes two problems. * Setting 'multiple' IDL attribute to false and removing 'multiple' content attribute had different behavior. They should be identical. This CL removes HTMLSelectElement::setMultiple(), and add [Reflect] to 'multiple' IDL attribute. * If multiple SELECT without selected OPTIONs is changed to single, we should run resetToDefaultSelection(). All other browsers agree with this behavior. BUG=599008 Committed: https://crrev.com/ed6cd6b785c97d4a678c262bbf5e62bf46e5a2e8 Cr-Commit-Position: refs/heads/master@{#384226}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix a typo in a comment #

Messages

Total messages: 21 (12 generated)
tkent
keishi, would you review this please?
4 years, 8 months ago (2016-03-30 13:08:16 UTC) #3
keishi
LGTM
4 years, 8 months ago (2016-03-31 02:23:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838183003/40001
4 years, 8 months ago (2016-03-31 02:29:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838183003/40001
4 years, 8 months ago (2016-03-31 06:13:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838183003/40001
4 years, 8 months ago (2016-03-31 08:16:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/166775)
4 years, 8 months ago (2016-03-31 08:30:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838183003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838183003/40001
4 years, 8 months ago (2016-03-31 09:02:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 09:07:03 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:08:05 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ed6cd6b785c97d4a678c262bbf5e62bf46e5a2e8
Cr-Commit-Position: refs/heads/master@{#384226}

Powered by Google App Engine
This is Rietveld 408576698