Propagate is_official_build to version script.

Propagate is_official_build to version script.

OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.

This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.

BUG=599268
Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
Cr-Commit-Position: refs/heads/master@{#384340}

[Peter Wen, 2016-03-31 15:56:57]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2016-03-31 15:56:58]

Hi Andrew,

Can you take a look at this GN action change and propagating the variable to the
version script?

Thanks, 🚏

Peter

[agrieve, 2016-03-31 17:02:10]

On 2016/03/31 15:56:58, Peter Wen wrote:
> Hi Andrew,
> 
> Can you take a look at this GN action change and propagating the variable to
the
> version script?
> 
> Thanks, 🚏
> 
> Peter

lgtm

[Peter Wen, 2016-03-31 17:32:43]

wnwen@chromium.org changed reviewers:
+ thestig@chromium.org

[Peter Wen, 2016-03-31 17:32:43]

+thestig for OWNERS //chrome/version.gni

[Lei Zhang, 2016-03-31 17:40:58]

lgtm

[Peter Wen, 2016-03-31 18:05:23]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2016-03-31 18:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838173005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838173005/1

[commit-bot: I haz the power, 2016-03-31 18:33:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-31 18:36:45]

Description was changed from

==========
Propagate is_official_build to version script.

OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.

This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.

BUG=599268
==========

to

==========
Propagate is_official_build to version script.

OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.

This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.

BUG=599268

Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
Cr-Commit-Position: refs/heads/master@{#384340}
==========

[commit-bot: I haz the power, 2016-03-31 18:36:47]

Patchset 1 (id:??) landed as
https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
Cr-Commit-Position: refs/heads/master@{#384340}

[Sami, 2016-04-01 16:55:21]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1851843002/ by skyostil@chromium.org.

The reason for reverting is: Made all the Android perf bots red:
https://bugs.chromium.org/p/chromium/issues/detail?id=599830.