Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1838173003: Revert changes to startup_metric_utils.cc. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert changes to startup_metric_utils.cc. I recently enabled some code on OS X that lets startup_metric_utils.cc set the thread priority (https://codereview.chromium.org/1620673003/). This is most likely responsible for a performance regression. BUG=595043 Committed: https://crrev.com/a5ce8d5bc18a08f44528b32ee8507dbb6982cf7d Cr-Commit-Position: refs/heads/master@{#384113}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/startup_metric_utils/browser/startup_metric_utils.cc View 1 2 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 17 (8 generated)
erikchen
robliao: Please review.
4 years, 8 months ago (2016-03-29 21:01:35 UTC) #2
robliao
Non-owner LGTM
4 years, 8 months ago (2016-03-29 22:32:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838173003/1
4 years, 8 months ago (2016-03-30 16:42:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/202413)
4 years, 8 months ago (2016-03-30 17:04:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838173003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838173003/40001
4 years, 8 months ago (2016-03-30 21:10:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-03-30 22:10:43 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a5ce8d5bc18a08f44528b32ee8507dbb6982cf7d Cr-Commit-Position: refs/heads/master@{#384113}
4 years, 8 months ago (2016-03-30 22:12:24 UTC) #14
gab
Mini-request + made comments on bug. https://codereview.chromium.org/1838173003/diff/40001/components/startup_metric_utils/browser/startup_metric_utils.cc File components/startup_metric_utils/browser/startup_metric_utils.cc (right): https://codereview.chromium.org/1838173003/diff/40001/components/startup_metric_utils/browser/startup_metric_utils.cc#newcode273 components/startup_metric_utils/browser/startup_metric_utils.cc:273: // thread priority ...
4 years, 8 months ago (2016-04-07 00:56:32 UTC) #16
gab
4 years, 8 months ago (2016-04-11 15:15:41 UTC) #17
Message was sent while issue was closed.
On 2016/04/07 00:56:32, gab wrote:
> Mini-request + made comments on bug.
> 
>
https://codereview.chromium.org/1838173003/diff/40001/components/startup_metr...
> File components/startup_metric_utils/browser/startup_metric_utils.cc (right):
> 
>
https://codereview.chromium.org/1838173003/diff/40001/components/startup_metr...
> components/startup_metric_utils/browser/startup_metric_utils.cc:273: // thread
> priority APIs (crbug.com/554651).
> Please update this comment.

ping, thanks

Powered by Google App Engine
This is Rietveld 408576698