[css-grid] Refactor positioned children code

[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
Committed: https://crrev.com/4c3299ff93c072a4c0b10947ab3f79622709f44f
Cr-Commit-Position: refs/heads/master@{#383708}

[Manuel Rego, 2016-03-29 10:58:41]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[Manuel Rego, 2016-03-29 10:58:42]

This is the first patch (refactoring) of the patch
to fix RTL issues in positioned children:
http://crrev.com/1824323002/

[Manuel Rego, 2016-03-29 11:37:00]

Description was changed from

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "ritght" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
==========

to

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
==========

[svillar, 2016-03-29 11:46:20]

lgtm. Much better code indeed

[Manuel Rego, 2016-03-29 11:55:45]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2016-03-29 11:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838173002/1

[jfernandez, 2016-03-29 12:24:35]

https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1528: if (isForColumns)
I think we must use an isXXAxis terminologym, instead this isForColumns/Rows
one.

https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1536: if (isForColumns)
Ditto

[commit-bot: I haz the power, 2016-03-29 13:05:21]

Description was changed from

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
==========

to

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
==========

[commit-bot: I haz the power, 2016-03-29 13:05:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-29 13:06:20]

Description was changed from

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882
==========

to

==========
[css-grid] Refactor positioned children code

This is a refactoring of LayoutGrid::offsetAndBreadthForPositionedChild()
in order to calculate offset and breadth in a more clean way.
Hopefully making the code easier to follow.

Thanks to the refactoring, now positioned children in RTL
are working fine if they use the static inline position
(when "left" and "right" properties are both "auto").

The other case (not having a static inline position)
will be fixed in a separated patch.

Added RTL cases for most of the positioned tests,
which are now passing with this patch.

Pending to add RTL tests when "left" and "right" are not "auto"
(the item doesn't use the static inline position),
but that will be done in the other patch.

BUG=568882

Committed: https://crrev.com/4c3299ff93c072a4c0b10947ab3f79622709f44f
Cr-Commit-Position: refs/heads/master@{#383708}
==========

[commit-bot: I haz the power, 2016-03-29 13:06:21]

Patchset 1 (id:??) landed as
https://crrev.com/4c3299ff93c072a4c0b10947ab3f79622709f44f
Cr-Commit-Position: refs/heads/master@{#383708}

[Manuel Rego, 2016-03-29 13:43:15]

On 2016/03/29 12:24:35, jfernandez wrote:
>
https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):
> 
>
https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1528: if (isForColumns)
> I think we must use an isXXAxis terminologym, instead this isForColumns/Rows
> one.
> 
>
https://codereview.chromium.org/1838173002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1536: if (isForColumns)
> Ditto

Yes, probably we should do a different patch changing this all over the place.

I'm not sure what's the best name though, my preference would be:
"isInlineAxis"