Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: pkg/barback/lib/src/asset_cascade.dart

Issue 183813006: Use zones to capture unexpected errors in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/lib/src/package_graph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/asset_cascade.dart
diff --git a/pkg/barback/lib/src/asset_cascade.dart b/pkg/barback/lib/src/asset_cascade.dart
index 16b4090334effbf86296b048b664f5b82f668260..8c30be3d0647a4b89d45e18b1c8674edf8ba0a98 100644
--- a/pkg/barback/lib/src/asset_cascade.dart
+++ b/pkg/barback/lib/src/asset_cascade.dart
@@ -274,17 +274,6 @@ class AssetCascade {
// TODO(rnystrom): Put some useful data in here.
_resultsController.add(
new BuildResult(_accumulatedErrors));
- }).catchError((error, stackTrace) {
- // If we get here, it's an unexpected error. Runtime errors like missing
- // assets should be handled earlier. Errors from transformers or other
- // external code that barback calls into should be caught at that API
- // boundary.
- //
- // On the off chance we get here, pipe the error to the results stream
- // as an error. That will let applications handle it without it appearing
- // in the same path as "normal" errors that get reported.
- _resultsController.addError(error, stackTrace);
- }).whenComplete(() {
_processDone = null;
_accumulatedErrors = null;
});
« no previous file with comments | « no previous file | pkg/barback/lib/src/package_graph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698