Use zones to capture unexpected errors in barback.

pkg/barback/lib/src/package_graph.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library barback.package_graph;
 
 import 'dart:async';
 
 import 'asset_cascade.dart';
 import 'asset_id.dart';
@@ skipping 53 matching lines @@
   /// This is used to pipe an unexpected error from a build to the resulting
   /// [Future] returned by [getAllAssets].
   var _lastUnexpectedError;
 
   /// The stack trace for [_lastUnexpectedError].
   StackTrace _lastUnexpectedErrorTrace;
 
   /// Creates a new [PackageGraph] that will transform assets in all packages
   /// made available by [provider].
   PackageGraph(this.provider) {
-    for (var package in provider.packages) {
-      var cascade = new AssetCascade(this, package);
-      // The initial result for each cascade is "success" since the cascade
-      // doesn't start building until some source in that graph is updated.
-      _cascadeResults[package] = new BuildResult.success();
-      _cascades[package] = cascade;
-      cascade.onDirty.listen((_) {
-        _cascadeResults[package] = null;
-      });
+    _inErrorZone(() {
+      for (var package in provider.packages) {
+        var cascade = new AssetCascade(this, package);
+        // The initial result for each cascade is "success" since the cascade
+        // doesn't start building until some source in that graph is updated.
+        _cascadeResults[package] = new BuildResult.success();
+        _cascades[package] = cascade;
+        cascade.onDirty.listen((_) {
+          _cascadeResults[package] = null;
+        });
 
-      cascade.onLog.listen((entry) {
-        if (_logController.hasListener) {
-          _logController.add(entry);
-        } else if (entry.level != LogLevel.FINE) {
-          // No listeners, so just print entry.
-          var buffer = new StringBuffer();
-          buffer.write("[${entry.level} ${entry.transform}] ");
+        cascade.onLog.listen((entry) {
+          if (_logController.hasListener) {
+            _logController.add(entry);
+          } else if (entry.level != LogLevel.FINE) {
+            // No listeners, so just print entry.
+            var buffer = new StringBuffer();
+            buffer.write("[${entry.level} ${entry.transform}] ");
 
-          if (entry.span != null) {
-            buffer.write(entry.span.getLocationMessage(entry.message));
-          } else {
-            buffer.write(entry.message);
+            if (entry.span != null) {
+              buffer.write(entry.span.getLocationMessage(entry.message));
+            } else {
+              buffer.write(entry.message);
+            }
+
+            print(buffer);
           }
+        });
 
-          print(buffer);
-        }
-      });
+        cascade.results.listen((result) {
+          _cascadeResults[cascade.package] = result;
+          // If any cascade hasn't yet finished, the overall build isn't finished

[Bob Nystrom, 2014/03/04 23:52:40]

Long line.

This method is pretty big. How about breaking the callbacks based to listen()
here and above into separate methods?

[nweiz, 2014/03/05 00:11:58]

Done.
Done.

+          // either.
+          if (_cascadeResults.values.any((result) => result == null)) return;
 
-      cascade.results.listen((result) {
-        _cascadeResults[cascade.package] = result;
-        // If any cascade hasn't yet finished, the overall build isn't finished
-        // either.
-        if (_cascadeResults.values.any((result) => result == null)) return;
+          // Include all build errors for all cascades. If no cascades have
+          // errors, the result will automatically be considered a success.
+          _resultsController.add(
+              new BuildResult.aggregate(_cascadeResults.values));
+        }, onError: (error, stackTrace) {
+          _lastUnexpectedError = error;
+          _lastUnexpectedErrorTrace = stackTrace;
+          _resultsController.addError(error, stackTrace);
+        });
+      }
 
-        // Include all build errors for all cascades. If no cascades have
-        // errors, the result will automatically be considered a success.
-        _resultsController.add(
-            new BuildResult.aggregate(_cascadeResults.values));
-      }, onError: (error, stackTrace) {
-        _lastUnexpectedError = error;
-        _lastUnexpectedErrorTrace = stackTrace;
-        _resultsController.addError(error, stackTrace);
-      });
-    }
-
-    _errors = mergeStreams(_cascades.values.map((cascade) => cascade.errors),
-        broadcast: true);
+      _errors = mergeStreams(_cascades.values.map((cascade) => cascade.errors),
+          broadcast: true);
+    });
   }
 
   /// Gets the asset node identified by [id].
   ///
   /// If [id] is for a generated or transformed asset, this will wait until it
   /// has been created and return it. This means that the returned asset will
   /// always be [AssetState.AVAILABLE].
   ///
   /// If the asset cannot be found, returns null.
   Future<AssetNode> getAssetNode(AssetId id) {
-    var cascade = _cascades[id.package];
-    if (cascade != null) return cascade.getAssetNode(id);
-    return new Future.value(null);
+    return _inErrorZone(() {
+      var cascade = _cascades[id.package];
+      if (cascade != null) return cascade.getAssetNode(id);
+      return new Future.value(null);
+    });
   }
 
   /// Gets all output assets.
   ///
   /// If a build is currently in progress, waits until it completes. The
   /// returned future will complete with an error if the build is not
   /// successful.
   ///
   /// Any transforms using [LazyTransformer]s will be forced to generate
   /// concrete outputs, and those outputs will be returned.
   Future<AssetSet> getAllAssets() {
     for (var cascade in _cascades.values) {
-      cascade.forceAllTransforms();
+      _inErrorZone(() => cascade.forceAllTransforms());
     }
 
     if (_cascadeResults.values.contains(null)) {
       // A build is still ongoing, so wait for it to complete and try again.
-      return results.first.then((_) => getAllAssets());
+      return results.first.then((_) => getAllAssets()) ;

[Bob Nystrom, 2014/03/04 23:52:40]

Extra space.

[nweiz, 2014/03/05 00:11:58]

Done.

     }
 
     // If an unexpected error occurred, complete with that.
     if (_lastUnexpectedError != null) {
       var error = _lastUnexpectedError;
       _lastUnexpectedError = null;
       return new Future.error(error, _lastUnexpectedErrorTrace);
     }
 
     // If the build completed with an error, complete the future with it.
@@ skipping 11 matching lines @@
 
   /// Adds [sources] to the graph's known set of source assets.
   ///
   /// Begins applying any transforms that can consume any of the sources. If a
   /// given source is already known, it is considered modified and all
   /// transforms that use it will be re-applied.
   void updateSources(Iterable<AssetId> sources) {
     groupBy(sources, (id) => id.package).forEach((package, ids) {
       var cascade = _cascades[package];
       if (cascade == null) throw new ArgumentError("Unknown package $package.");
-      cascade.updateSources(ids);
+      _inErrorZone(() => cascade.updateSources(ids));
     });
   }
 
   /// Removes [removed] from the graph's known set of source assets.
   void removeSources(Iterable<AssetId> sources) {
     groupBy(sources, (id) => id.package).forEach((package, ids) {
       var cascade = _cascades[package];
       if (cascade == null) throw new ArgumentError("Unknown package $package.");
-      cascade.removeSources(ids);
+      _inErrorZone(() => cascade.removeSources(ids));
     });
   }
 
   void updateTransformers(String package,
       Iterable<Iterable<Transformer>> transformers) {
-    _cascades[package].updateTransformers(transformers);
+    _inErrorZone(() => _cascades[package].updateTransformers(transformers));
+  }
+
+  /// Run [body] in an error-handling [Zone] and pipe any unexpected errors to
+  /// the error channel of [results].
+  ///
+  /// [body] can return a value or a [Future] that will be piped to the returned
+  /// [Future]. If it throws a [BarbackException], that exception will be piped
+  /// to the returned [Future] as well. ANy other exceptions will be piped to

[Bob Nystrom, 2014/03/04 23:52:40]

"ANy" -> "Any"

[nweiz, 2014/03/05 00:11:58]

Done.

+  /// [results].
+  Future _inErrorZone(body()) {
+    var completer = new Completer.sync();
+    runZoned(() {
+      syncFuture(body).then(completer.complete).catchError((error, stackTrace) {
+        if (error is! BarbackException) throw error;
+        completer.addError(error, stackTrace);
+      });
+    }, onError: (error, stackTrace) {
+      _lastUnexpectedError = error;
+      _lastUnexpectedErrorTrace = stackTrace;
+      _resultsController.addError(error, stackTrace);
+    });
+    return completer.future;
   }
 }