Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1838083003: mb: Add src-side changes for a new "win_clang" bot. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mb: Add src-side changes for a new "win_clang" bot. I want to use this bot as the default-on win/clang trybot, so that if I need to modify it (change it to release, or make it use LLD, or make it build fewer targets then "all"), I don't have to modify our existing FYI waterfall bots. BUG=588518 Committed: https://crrev.com/abebbb1798c8ca104f8ec7e607ddeb0b93994682 Cr-Commit-Position: refs/heads/master@{#383909}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Nico
4 years, 8 months ago (2016-03-29 22:01:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/1
4 years, 8 months ago (2016-03-29 22:05:09 UTC) #4
Dirk Pranke
lgtm https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl#newcode204 tools/mb/mb_config.pyl:204: 'WinClang': 'win_clang_debug_bot', nit: please sort by builder name, ...
4 years, 8 months ago (2016-03-29 22:42:14 UTC) #5
Dirk Pranke
but, see my comment on the build-side CL about the choice of builder name (i.e., ...
4 years, 8 months ago (2016-03-29 22:45:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 23:41:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/1
4 years, 8 months ago (2016-03-30 01:52:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/161855)
4 years, 8 months ago (2016-03-30 01:58:38 UTC) #12
Nico
https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl#newcode204 tools/mb/mb_config.pyl:204: 'WinClang': 'win_clang_debug_bot', On 2016/03/29 22:42:14, Dirk Pranke wrote: > ...
4 years, 8 months ago (2016-03-30 02:15:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/40001
4 years, 8 months ago (2016-03-30 02:15:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/124063)
4 years, 8 months ago (2016-03-30 02:30:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/40001
4 years, 8 months ago (2016-03-30 02:33:44 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 04:29:19 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 04:30:29 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/abebbb1798c8ca104f8ec7e607ddeb0b93994682
Cr-Commit-Position: refs/heads/master@{#383909}

Powered by Google App Engine
This is Rietveld 408576698