|
|
Created:
4 years, 8 months ago by Nico Modified:
4 years, 8 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmb: Add src-side changes for a new "win_clang" bot.
I want to use this bot as the default-on win/clang trybot, so that if I need
to modify it (change it to release, or make it use LLD, or make it build fewer
targets then "all"), I don't have to modify our existing FYI waterfall bots.
BUG=588518
Committed: https://crrev.com/abebbb1798c8ca104f8ec7e607ddeb0b93994682
Cr-Commit-Position: refs/heads/master@{#383909}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase #Patch Set 3 : comment #Messages
Total messages: 23 (10 generated)
thakis@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/1
lgtm https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:204: 'WinClang': 'win_clang_debug_bot', nit: please sort by builder name, so this probably goes down to line 212.
but, see my comment on the build-side CL about the choice of builder name (i.e., hopefully we can pick something less confusing).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1838083003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:204: 'WinClang': 'win_clang_debug_bot', On 2016/03/29 22:42:14, Dirk Pranke wrote: > nit: please sort by builder name, so this probably goes down to line 212. Done.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1838083003/#ps40001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838083003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== mb: Add src-side changes for a new "win_clang" bot. I want to use this bot as the default-on win/clang trybot, so that if I need to modify it (change it to release, or make it use LLD, or make it build fewer targets then "all"), I don't have to modify our existing FYI waterfall bots. BUG=588518 ========== to ========== mb: Add src-side changes for a new "win_clang" bot. I want to use this bot as the default-on win/clang trybot, so that if I need to modify it (change it to release, or make it use LLD, or make it build fewer targets then "all"), I don't have to modify our existing FYI waterfall bots. BUG=588518 Committed: https://crrev.com/abebbb1798c8ca104f8ec7e607ddeb0b93994682 Cr-Commit-Position: refs/heads/master@{#383909} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/abebbb1798c8ca104f8ec7e607ddeb0b93994682 Cr-Commit-Position: refs/heads/master@{#383909} |