Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 1838073002: [ios] Removed CRWWebUserInterfaceDelegate usage from ios_web_shell. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed CRWWebUserInterfaceDelegate usage from ios_web_shell. CRWWebUserInterfaceDelegate was added to web shell to test auth and is unnecessary now. Web shell must use only public web// API and CRWWebUserInterfaceDelegate is not public. BUG=597997 Committed: https://crrev.com/f375c04bed160193a46806a2a471513c6c217001 Cr-Commit-Position: refs/heads/master@{#383806}

Patch Set 1 #

Patch Set 2 : Merged with origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M ios/web/shell/view_controller.mm View 1 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838073002/1
4 years, 8 months ago (2016-03-29 04:21:07 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 04:52:08 UTC) #4
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-03-29 14:20:16 UTC) #6
kkhorimoto
lgtm
4 years, 8 months ago (2016-03-29 18:07:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838073002/1
4 years, 8 months ago (2016-03-29 18:08:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/161582)
4 years, 8 months ago (2016-03-29 18:14:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838073002/20001
4 years, 8 months ago (2016-03-29 20:04:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 20:38:06 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:39:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f375c04bed160193a46806a2a471513c6c217001
Cr-Commit-Position: refs/heads/master@{#383806}

Powered by Google App Engine
This is Rietveld 408576698